fix(ui5-split-button): announce accessible name before instructions - #13901
Merged
Conversation
Todor-ads
temporarily deployed
to
netlify-preview
August 10, 2026 06:17 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13901--ui5-webcomponents-preview.netlify.app |
unazko
reviewed
Aug 11, 2026
Contributor
There was a problem hiding this comment.
The custom role "Split Button" is not getting announced in JAWS. With NVDA it gets announced at the end and it should be announced after the accessible name announcement (the same as in openui5 split button).
In order to fix this custom role announcement inconsistency we should move the "Split Button" text from aria-roldescription attribute to the aria-label attribute instead (placing the custom role text directly after the accessible name).
Todor-ads
temporarily deployed
to
netlify-preview
August 13, 2026 06:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
unazko
reviewed
Aug 14, 2026
Todor-ads
temporarily deployed
to
netlify-preview
August 14, 2026 08:55 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Todor-ads
force-pushed
the
split_button_annonce_order
branch
from
August 14, 2026 10:53
9e86420 to
ae867ef
Compare
Todor-ads
temporarily deployed
to
netlify-preview
August 14, 2026 10:53 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
unazko
previously approved these changes
Aug 14, 2026
Todor-ads
temporarily deployed
to
netlify-preview
August 17, 2026 06:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Todor-ads
temporarily deployed
to
netlify-preview
August 17, 2026 10:48 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Todor-ads
temporarily deployed
to
netlify-preview
August 17, 2026 11:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Todor-ads
temporarily deployed
to
netlify-preview
August 17, 2026 11:50 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
GDamyanov
previously requested changes
Aug 17, 2026
Todor-ads
temporarily deployed
to
netlify-preview
August 28, 2026 06:59 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
unazko
reviewed
Aug 31, 2026
Todor-ads
temporarily deployed
to
netlify-preview
August 31, 2026 12:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
unazko
reviewed
Aug 31, 2026
Todor-ads
temporarily deployed
to
netlify-preview
September 1, 2026 04:47 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
unazko
approved these changes
Sep 1, 2026
NHristov-sap
approved these changes
Sep 2, 2026
Todor-ads
temporarily deployed
to
netlify-preview
September 3, 2026 06:31 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
vladitasev
temporarily deployed
to
netlify-preview
September 3, 2026 06:55 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
🧹 Preview deployment cleaned up: https://pr-13901--ui5-webcomponents.netlify.app |
|
🎉 This PR is included in version v2.27.0-rc.1 🎉 The release is available on v2.27.0-rc.1 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen readers were announcing the keyboard usage instructions before the accessible name of the button, because keyboardHint was placed before accessibleName in the invisibleText span.
The fix swaps their order so the accessible name is announced immediately after the button label, followed by the instructions.
Fixes: #13841